4.76.22

[Jason Ede]

>From some more digging and inserting debug statements it seems to be something on one of these 2 lines.

$FoundBodyEnd = 1 if $line =~ s/\<\/body\>/$signature$&/i;
$FoundHTMLEnd = 1 if !$FoundBodyEnd && $line =~ s/\<\/x?html\>/$signature$&/i;

If I comment both of them out then it seems to work, but I'm betting it breaks something else. Is it a odd combination of html tags at the end of the email that triggers this again?

Jason

> -----Original Message-----
> From: mailscanner-bounces at lists.mailscanner.info [mailto:mailscanner-
> bounces at lists.mailscanner.info] On Behalf Of Jason Ede
> Sent: 29 April 2009 08:28
> To: MailScanner discussion
> Subject: RE: 4.76.22
> 
> I've been trying this morning to break it using blat to send text based
> emails (email-plain) to the server and its been working perfectly. I
> then used blat again with source copied from an outlook email (email-
> html) that shows the problem and it does append an extra signature on
> the end every time. I'll try some more debug on this later by adding
> some debug lines into the code. I've attached the 2 text files that
> I've been using.
> 
> ________________________________________
> From: mailscanner-bounces at lists.mailscanner.info [mailscanner-
> bounces at lists.mailscanner.info] On Behalf Of Julian Field
> [MailScanner at ecs.soton.ac.uk]
> Sent: 28 April 2009 20:40
> To: MailScanner discussion
> Subject: Re: 4.76.22
> 
> On 28/04/2009 20:19, Jason Ede wrote:
> > I've been testing the _SIGNATURE_ option here and it seems that it
> > always adds the signature at the end as well as in the message at the
> > signature tags. I'm using html sigs with an inline image. I've taken
> > at look at what I think is the code in message.pm but it all looks
> > correct to me :(
> >
> Yes, I have looked too, when someone else commented they were getting
> the sig at the end too. But the code is incredibly simple and I can't
> see anything wrong with it either.
> FoundSigMark = 0
> FoundSigMark = 1 if we successfully replace _SIGNATURE_ with the
> signature text.
> print signature text at end of message unless FoundSigMark is non-zero.
> That's all there is to it.
> > I don't need to change something in the config to stop it signing at
> the end as well?
> >
> No.
> If you could try adding some lines like
>      print STDERR "FoundSigMark = $FoundSigMark\n"; lines into the code
> at suitable places, then run it on your system with "MailScanner --
> debug" and see what it prints, that would really help me debug it.
> 
> Many thanks.
> >> -----Original Message-----
> >> From: mailscanner-bounces at lists.mailscanner.info
> [mailto:mailscanner-
> >> bounces at lists.mailscanner.info] On Behalf Of Julian Field
> >> Sent: 28 April 2009 11:56
> >> To: MailScanner discussion
> >> Subject: 4.76.22
> >>
> >> I have just released a new beta, this will be one of the last before
> >> the next stable release.
> >> Please test it, as I have optimised the processing-messages database
> >> code, and fixed one or two little bugs. The Change Log will tell you
> >> all the details.
> >>
> >> Download as usual from www.mailscanner.info.
> >>
> 
> Jules
> 
> --
> Julian Field MEng CITP CEng
> www.MailScanner.info
> Buy the MailScanner book at www.MailScanner.info/store
> 
> MailScanner customisation, or any advanced system administration help?
> Contact me at Jules at Jules.FM
> 
> PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654 PGP
> public key: http://www.jules.fm/julesfm.asc Follow me at
> twitter.com/JulesFM
> 
> 
> --
> This message has been scanned for viruses and dangerous content by
> MailScanner, and is believed to be clean.
> 
> --
> MailScanner mailing list
> mailscanner at lists.mailscanner.info
> http://lists.mailscanner.info/mailman/listinfo/mailscanner
> 
> Before posting, read http://wiki.mailscanner.info/posting
> 
> Support MailScanner development - buy the book off the website!