On 30/05/2010 05:31, PSI Mailbag wrote:
>> Sorry about that, you're absolutely right. Trivial fix. Find the line
>> in the patch that says
>> push @tmplist, $tmplist1;
>> and change it to
>> push @tmplist, $tmplist1 unless -d $tmplist1;
>>
>> Then give it another go.
>>
> Maybe I'm missing something, but this line wasn't in the patch you sent
> to the list. Was this supposed to be after "$tmplist1 = $1;"? If so, is
> it safe to backport this patch to 4.79.11? Is there anything I need to
> watch out for if I add in the missing "push" to the patch and match the
> "JFK 20100211" changes (as shown in your diff) in that section of the
> module?
>
The entire chunk of code just there in Message.pm should look like this:
# Set the owner and group on all the extracted files
# JKF 20100211 chown $workarea->{uid}, $workarea->{gid}, map {
m/(.*)/ } grep { -f } glob "$explodeinto/* $explodeinto/.*"
# JKF 20100211 if $workarea->{changeowner};
my($tmplist1, at tmplist);
if ($workarea->{changeowner}) {
foreach $tmplist1 (glob "$explodeinto/* $explodeinto/.*") {
$tmplist1 =~ /(.*)/;
$tmplist1 = $1;
push @tmplist, $tmplist1 unless -d $tmplist1;
}
chown $workarea->{uid}, $workarea->{gid}, @tmplist if @tmplist;
}
# JKF 20100528 Now set the perms on all the extracted files
my $workperms = MailScanner::Config::Value('workperms') || '0600';
# Make it octal with a leading zero if necessary
$workperms = sprintf "0%lo", $workperms unless $workperms =~ /^0/;
$workperms = oct($workperms); # and back to decimal for chmod
chmod $workperms, @tmplist if @tmplist;
}
> I would like to test out the patch, but would prefer to stay on the last
> stable for this particular server..
>
>
>
>
>> You are running a much more recent version of Archive::Zip than the
>>
> one
>
>> I distribute, which would explain why only a few people are seeing the
>> problem. I distribute 1.16 and this doesn't cause this problem to show
>> itself.
>>
> My particular Archive::Zip (1.24) is from the FSL Gold repo.. which
> you're technically the CTO of, right? ;-)
>
Doesn't mean I put together that particular repo...
>
>
> As an aside, today marks my 2,500th day running MailScanner! Oddly
> enough, it's also the same day that we hit 6 TB of content being
> processed by MailScanner. Thanks for your time over the years, Jules!
>
No probs :-)
Jules
--
Julian Field MEng CITP CEng
www.MailScanner.info
Buy the MailScanner book at www.MailScanner.info/store
Need help customising MailScanner?
Contact me!
Need help fixing or optimising your systems?
Contact me!
Need help getting you started solving new requirements from your boss?
Contact me!
PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654
Follow me at twitter.com/JulesFM and twitter.com/MailScanner
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.