milters with postfix

[Glenn Steen]

On 22/06/07, Glenn Steen <glenn.steen at gmail.com> wrote:
> Get me a sample. . . T9 playing tricks on me:)
>
> On 22/06/07, Glenn Steen <glenn.steen at gmail.com> wrote:
> > Could you get of a sample queue file? Both before and after?
> >
> > On 22/06/07, Nerijus Baliunas <nerijusb at dtiltas.lt> wrote:
> > > Hello,
> > >
> > > I updated to postfix 2.4.3 and mailscanner 4.61.3 and the old problem
> > > with corrupted headers is back again. But the "   0" is added not after
> > > the last header as before, but in the middle of the headers:
> > >
> > > From: Nerijus Baliunas <xxx at example.lt>
> > > Subject: 2
> > >   0
> > > To: postmaster at example.lt
> > >
> > > Any ideas? Should I provide email samples and queue files again?
> > >
> > > Regards,
> > > Nerijus

Well, thanks to Nerijus, who sent a comprehensive set of queue files
and the corresponding (mangled) results, I now see that something (in
MailScanner) has botched the w (deleted) record in the problem case
...
When I find them in the body, I simply ignore them, but in the header
section(s) I fall back on Jules sane thing of simply copying them over
as is ... This seems to be less than working though, so I'll either do
a patch (next week) to simply skip them in the header(s) too, or try
make sure they don't get mangled (if I can find out why).
The first method is quite sane, since we really don't need them... And
it just might be that we should (contraintuitively) do the
"reintroduction of an empty p record" I talked about a while back, if
postfix itself relies on the occurrence of p records to correctly
handle w records (I haven't checked the PF code for this... Just might
be something like that happening... Sigh).
When I do something about this, I'll do the fix for Fred Stein too, to
only do the body spin-through in ReadQf for queue files containing p
records... Thinking like Linus.... "Don't sacrifice the common case
performance for the odd case":-).

Since I'm off celebrating a traditional midsummer's eve (with all that
entails (see how restrained I am, Hugo:-)) I wouldn't trust any code
leaving my fingers ... So it'll have to be sometime Monday or Tuesday
... at the earliest:-)

BTW Jules, when you feel a bit better you really should come sample
the pickled herring ... and ... assorted attributes...:-). Would be a
shame if the world tour was on hold indefinitely;-)

Cheers
-- 
-- Glenn
email: glenn < dot > steen < at > gmail < dot > com
work: glenn < dot > steen < at > ap1 < dot > se