ClamAV module logging changed in 4.62

[Julian Field]

Rick Cooper wrote:
>  
>
>  > -----Original Message-----
>  > From: mailscanner-bounces at lists.mailscanner.info 
>  > [mailto:mailscanner-bounces at lists.mailscanner.info] On 
>  > Behalf Of Joshua Hirsh
>  > Sent: Wednesday, August 08, 2007 9:56 AM
>  > To: MailScanner discussion
>  > Subject: RE: ClamAV module logging changed in 4.62
>  > 
>  > > Ok I had a look this morning and the only reason I can see 
>  > > would be having the display scanner name set to no. And
>  > > BTW, The Sohpos scanner name is hard coded so it would
>  > > display regardless. The setting in MailScanner.conf you
>  > > are looking for is: Include Scanner Name In Reports =  and
>  > > it is probably set to no and should be set to yes.
>  > 
>  > 
>  > This value has always been set to yes on my server, but the 
>  > ClamAV name
>  > stopped showing up anyways..
>  > 
>  > The bug is on line 1439 of SweepViruses.pm (in the
>  > ProcessClamAVModOutput subroutine). If you change this line:
>  > 	MailScanner::Log::InfoLog("$Name::%s", $logout);
>  > to this line:
>  > 	 MailScanner::Log::InfoLog($Name . "::%s", $logout);
>  > The name will display properly in the logs. However, this 
>  > may not be the
>  > "proper" fix, and it may still exist in other areas. In a 
>  > quick test, it
>  > fixed it for me..
>  > 
>
> Julian I have to ask WTF? That should be functionally the same?
>   
No. If it treats Name as the name of a package, then $Name::hello is the 
value of the variable "hello" within the package "Name".
> In any case it would be more correct to use
> MailScanner::Log::InfoLog("%s::%s",$Name, $logout);
>   
It would indeed. I'll do that.
> Rick
>
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>
>   

Jules

-- 
Julian Field MEng CITP
www.MailScanner.info
Buy the MailScanner book at www.MailScanner.info/store

Need help customising MailScanner?
Contact me!
Need help fixing or optimising your systems?
Contact me!
Need help getting you started solving new requirements from your boss?
Contact me!

PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654


-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
For all your IT requirements visit www.transtec.co.uk