Spam Check rule file issues and checking order.

[Julian Field]

    [ The following text is in the "ISO-8859-1" character set. ]
    [ Your display is set for the "US-ASCII" character set.  ]
    [ Some characters may be displayed incorrectly. ]

Bob Jones wrote:

> Now for an even weirder (in my mind at least) issue.  So, we move the
> SpamChecks line in ConfigDefs.pl to the [All,YesNo] section.  If we send
> a message originating from IP address 168.24.85.103 (which is in the
> rules file to not be scanned) to ourdesk at usg.edu (which is also in the
> rules file to not be scanned), the message is scanned.  If only one of
> those 2 criteria is used, the message is not scanned (correct result),
> but with both criteria the message *is* scanned.  Any idea what is going
> on with that?

That's a bug. I just fixed it.
In MessageBatch.pm there is a chunk of code like this:

sub SpamChecks {
  my $this = shift;

  my($id, $message);
  my $counter = 0;

  #print STDERR "Starting spam checks\n";

  MailScanner::Log::InfoLog("Spam Checks: Starting")
    if MailScanner::Config::Value('logspam');

  while(($id, $message) = each %{$this->{messages}}) {
    next if $message->{deleted};
    next unless MailScanner::Config::Value('spamchecks', $message) =~ /1/;

Note the change to the last line.

--
Julian Field
www.MailScanner.info
Buy the MailScanner book at www.MailScanner.info/store
Professional Support Services at www.MailScanner.biz
MailScanner thanks transtec Computers for their support

PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654

------------------------ MailScanner list ------------------------
To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
'leave mailscanner' in the body of the email.
Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).

Support MailScanner development - buy the book off the website!