<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Ok, I can’t tell if you are happy about v5 or not. So, here is some of the logic:<div class=""><br class=""></div><div class=""><br class=""></div><div class="">- I put the config in /etc/MailScanner/defaults because configs are in a different place on every distro. This keeps it in one place no matter what distro you are using. I support a lot of different distros, and trying to find it in 5 different places on 5 different distros is a pain in the ass. I would suggest leaving it where it is and using a symlink for your distro. </div><div class=""><br class=""></div><div class="">- The same logic was used for ms-init, /var/lock/subsys/Mailscanner, and /var/log/MailScanner.off</div><div class=""><div class=""><div class="">
<div style="color: rgb(0, 0, 0); font-family: Tahoma; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><br class="">- run_mailscanner is in place so that MailScanner does not get started accidentally before MailScanner.conf has been setup. </div><div style="color: rgb(0, 0, 0); font-family: Tahoma; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><br class=""></div><div style="color: rgb(0, 0, 0); font-family: Tahoma; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">- The PID of the mater process is put in the PID file. If ms-check does not find a matching PID of what it should be, it restarts everything. </div><div style="color: rgb(0, 0, 0); font-family: Tahoma; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><br class=""></div><div style="color: rgb(0, 0, 0); font-family: Tahoma; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><br class=""></div><div style="color: rgb(0, 0, 0); font-family: Tahoma; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;">If you have some suggestions for changes that will work across all distros, please do post it here so I can review and implement them. </div><div style="color: rgb(0, 0, 0); font-family: Tahoma; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><br class=""></div><div style="color: rgb(0, 0, 0); font-family: Tahoma; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><br class=""></div><div style="color: rgb(0, 0, 0); font-family: Tahoma; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;"><br class="">Jerry Benton<br class=""><a href="http://www.mailborder.com" class="">www.mailborder.com</a><br class="">+1 - 844-436-6245<br class=""><br class=""><br class=""></div>
</div>
<br class=""><div><blockquote type="cite" class=""><div class="">On Nov 13, 2016, at 4:00 PM, Michael Weiser <<a href="mailto:michael@weiser.dinsnail.net" class="">michael@weiser.dinsnail.net</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hey guys and especially Jerry,<br class=""><br class="">I know I'm ridiculously late to the party here but I still need to get<br class="">this off my chest: Jerry, you're my hero! :)<br class=""><br class="">I just updated my Gentoo-based MailScanner installation from something<br class="">ancient to MailScanner 5.0.3-7 and just couldn't believe how insanely<br class="">sane this new MailScanner is. So I went right ahead and reworked the<br class="">Gentoo package to reflect that.<br class=""><br class="">I couldn't resist sticking with Gentoo's /etc/conf.d for what<br class="">/etc/MailScanner/defaults does now. Also I couldn't bring myself to even<br class="">try to install ms-init and stuck with an updated openrc<br class="">start-stop-daemon-based init script. And finally I patched around in<br class="">ms-check because I couldn't really wrap my head around the benefit of<br class="">having a stopped_lockfile *and* a run_mailscanner setting. I've tried to<br class="">formulate my thoughts on all this in a README.Gentoo<br class="">(<a href="https://584524.bugs.gentoo.org/attachment.cgi?id=453228" class="">https://584524.bugs.gentoo.org/attachment.cgi?id=453228</a>).<br class=""><br class="">Anyway, I found an already open bug on updating the Gentoo package and<br class="">stuck my stuff into it. There's lots of explanations and rationale in<br class="">the ebuild, the ms-check patch and the README.Gentoo if anyone's<br class="">interested: <a href="https://bugs.gentoo.org/show_bug.cgi?id=584524" class="">https://bugs.gentoo.org/show_bug.cgi?id=584524</a>.<br class="">Now we'll have to see if it gets picked up.<br class=""><br class="">Here are some additional points for your consideration hidden away as<br class="">comments in the ebuild:<br class=""><br class="">On /etc/conf.d/MailScanner (aka /etc/MailScanner/defaults):<br class="">- nothing is using the ms_re2c setting (ms-update-sa finds it on its own)<br class="">- ms_etc isn't used anywhere<br class=""><br class="">On calls to ms-init in /usr/sbin/ms-update-bad-emails and<br class="">/usr/sbin/ms-update-sa:<br class=""><br class="">change restarts via ms-init after e.g. rules updates into<br class="">reloads via /etc/init.d/MailScanner<br class="">a.) reloads should be enough because they restart all children and the<br class=""> parent MailScanner doesn't do anything so doesn't need the update<br class="">b.) this way we'll never accidentally start MailScanner when it's<br class=""> supposed to be switched off without mucking about with<br class=""> $run_mailscanner and $stopped_lockfile<br class=""><br class="">What I mean there is: A simple SIGHUP instead of ms-init restart<br class="">should do the trick and be safer at the same time, shouldn't it?<br class=""><br class="">Feel free to bash me (a bit :) for stuff I got wrong.<br class=""><br class="">And thanks again! This is awesome! :)<br class="">-- <br class="">Michael<br class=""><br class=""><br class="">-- <br class="">MailScanner mailing list<br class=""><a href="mailto:mailscanner@lists.mailscanner.info" class="">mailscanner@lists.mailscanner.info</a><br class="">http://lists.mailscanner.info/mailman/listinfo/mailscanner<br class=""><br class=""></div></div></blockquote></div><br class=""></div></div></body></html>