Bad phishing site update script problems

[Mark Sapiro]

On 03/03/2014 06:26 PM, Mark Sapiro wrote:
> On 03/03/2014 05:57 PM, David Lee wrote:
>> Hi All,
>>
>> Is anybody else seeing problems with updates of the
>> 'phishing.bad.sites.conf' file?
>> When I try to run the update script, I see the following:
>>
> ...
>> I am working with: Current: 2014-092 - 99 and Status: -1 - 0
>> This is base update
>> Unable to retrieve http://cdn.mailscanner.info/.2014-092 :404 Not Found


If you are seeing these issues with update_bad_phishing_sites and/or
Scamnailer, you can avoid this with these patches

--- /usr/sbin/update_bad_phishing_sites.mas	2013-10-02
21:25:07.000000000 -0700
+++ /usr/sbin/update_bad_phishing_sites	2014-03-04 10:38:26.000000000 -0800
@@ -145,7 +145,8 @@
 my $janone = (gmtime(timegm(0,0,0,1,0,$year-1900)))[6];
 my $week = sprintf ("%02d", int (((gmtime)[7] + $janone) / 7));
 my $mybase = "$year-$week$day";
-if ($currentbase lt $mybase) {
+#if ($currentbase lt $mybase) {
+if ($currentbase eq 0) {
   $currentbase = $mybase;
   $currentupdate = 99;
 }



--- .cron/ScamNailer.new	2013-06-19 13:08:56.000000000 -0700
+++ .cron/ScamNailer	2014-03-04 10:36:53.000000000 -0800
@@ -226,7 +229,8 @@
   my $janone = (gmtime(timegm(0,0,0,1,0,$year-1900)))[6];
   my $week = sprintf ("%02d", int (((gmtime)[7] + $janone) / 7));
   my $mybase = "$year-$week$day";
-  if ($currentbase lt $mybase) {
+#  if ($currentbase lt $mybase) {
+  if  ($currentbase eq 0) {
     $currentbase = $mybase;
     $currentupdate = 99;
   }


These changes will prevent losing the files all together if the data
files and the DNS TXT records at msupdate.greylist.bastionmail.com and
emails.msupdate.greylist.bastionmail.com are not being updated as is the
current case.

However, if as was the case a few months ago, only the DNS TXT records
are not updated, this will defeat the patch which would correctly guess
the updates.

Also, if your files do not have the line

 if ($currentbase lt $mybase) {

this doesn't apply to you.

-- 
Mark Sapiro <mark at msapiro.net>        The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan