update_spamassassin does unnecessary sa_compile and doesn't remove log.

Jules Field MailScanner at ecs.soton.ac.uk
Mon Jan 11 13:20:49 GMT 2010

Many thanks for that. Incorporated in to the next release.

On 27/12/2009 16:47, Mark Sapiro wrote:
> The /usr/sbin/update_spamassassin script doesn't properly handle the
> exit status from sa_update.
> In particular, an exit status of 1 means no fresh updates were
> available. In this case and also probably in error cases (exit status
>> 1), sa-compile should not be run. Also, an exit status of 1 should
> not retain the log.
> I suggest the patch in the attached diff.txt to fix both issues.


Julian Field MEng CITP CEng
Buy the MailScanner book at www.MailScanner.info/store

Need help customising MailScanner?
Contact me!
Need help fixing or optimising your systems?
Contact me!
Need help getting you started solving new requirements from your boss?
Contact me!

PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654
Follow me at twitter.com/JulesFM and twitter.com/MailScanner

This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

More information about the MailScanner mailing list