Configuration suggestion...

[Rick Cooper]

----Original Message----
From: mailscanner-bounces at lists.mailscanner.info
[mailto:mailscanner-bounces at lists.mailscanner.info] On Behalf Of Julian
Field Sent: Tuesday, August 11, 2009 5:31 AM To: MailScanner discussion
Subject: Re: Configuration suggestion...

> On 11/08/2009 10:13, Glenn Steen wrote:
>> 2009/8/11 shuttlebox<shuttlebox at gmail.com>:
>> 
>>> On Tue, Aug 11, 2009 at 10:13 AM, Julian
>>> Field<MailScanner at ecs.soton.ac.uk>  wrote:
>>> 
>>>> Adding "include" files means that I need to allow settings to be
>>>> over-written by later instances of the same setting, and I need to keep
>>>> track of a whole stack of nested "include" files. Currently it will
>>>> complain if it sees the same setting twice, but I would have to
>>>> disable that, which I'm not keen on doing. And in the nested "include"
>>>> file handling, I've got to do loop detection and other nasties so you
>>>> can't trivially break it. 
>>>> 
>>> You could use MailScanner.conf as the master and the only one allowed
>>> to include other files. Then just let settings override each other.
>>> That's simple and good enough in my opinion, I doubt anyone _really_
>>> needs nesting. 
>>> 
>>> 
>> I rather doubt anyone *really* needs includes either. The upgrade
>> process is very fast and simple IMO, and this isn't one of the trickier
>> parts. I further wouldn't want the upgrade script to run automatically,
>> but that might be just me:-) 
>> 
> Well, you now have fully nested "include" lines, which also support
> wildcards. A sample valid line is
>      include /etc/MailScanner/conf/*.conf
> Included files can include arbitrary numbers of other include files, and
> so on.
> 
> Even the upgrade_MailScanner_conf file should cope with the new syntax,
> and will just upgrade the MailScanner.conf file it is given on the
> command-line, it will not follow include paths.
> 
> 4.78.8-1 is where it's all at :-)
> 
> Happier now? ;->
> 
> Jules

I don't know how you implemented it but you might want to include a hard
coded max nested limit just in case someone includes a file that includes a
predecessor. Exim uses something similar to prevent a run away in recursive
calls to acls and, I believe, nested includes.

Rick


--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.