Improvements to install.sh ?

Alex Broens ms-list at alexb.ch
Mon Sep 29 21:59:29 IST 2008


On 9/29/2008 6:56 PM, Kevin Miller wrote:
> Alex Broens wrote:
>> On 9/29/2008 6:17 PM, Kevin Miller wrote:
>>   > When the combined spam/av script runs it adds the same three or
>> four 
>>> lines to each .pre file.  As you've noted in the past, it's harmless
>>> to add them in multiple times.  But it would be cleaner if they were
>>> just added to the latest.  Nothing to lose sleep over, just a little
>>> extra cruft to wade through when/if debugging.
>> the .pre files belong to SpamAssassin and shouldn't ever be
>> touched/modified by MailScanner.
>>
>> If the files are missing, it would be acceptable to have MailScanner
>> add them, but to overwrite existing files should be avoided by all
>> means. 
> 
> It's during the clamAV/spamassassin install, not the MailScanner install
> (which I mentioned above).  I know the discussion is the MailScanner
> install, but knowing that Julian is usually pretty thorough I figured
> I'd add that in on the off chance he'll be looking to improve both
> scripts.

Sorry mixed them up...


> Obviously when installing spamassassin it's acceptable that one would
> touch it's related config files...

by SA's make process yes, and that will never overwrite user conf = 
*.pre files

Alex



More information about the MailScanner mailing list