minor bug in 4.64.1-1

[Randal, Phil]

Julian,

There's a minor bug in MS 4.64.1-1 in Message.pm, to do with the new
feature of adding points to SA score when "Treat Invalid Watermarks With
No Sender as Spam" is set to a number greater than zero.

You test the spamminess based on the number to increment by, instead of
the revised score.

The patch is trivial:

--- Message.pm.old      2007-09-28 15:41:32.000000000 +0100
+++ Message.pm  2007-09-28 15:43:15.000000000 +0100
@@ -548,8 +548,8 @@
     }
     # spam/high/normal can also be a number, which is added to the Spam
Score
     elsif (($mshmacnull+0.0) > 0.01) {
-      my($mshspam, $mshhigh) = MailScanner::SA::SATest_spam($this, 0.0,
$mshmacnull+0.0);
       $this->{sascore} += $mshmacnull+0.0;
+      my($mshspam, $mshhigh) = MailScanner::SA::SATest_spam($this, 0.0,
$this->{sascore});
       $this->{isspam} = 1 if $mshspam;
       $this->{ishigh} = 1 if $mshhigh;
       $this->{spamreport} = ($mshspam?$LocalSpamText:$LocalNotSpamText)
. "(no\
 watermark or sender address)";


Cheers,

Phil
--
Phil Randal
Network Engineer
Herefordshire Council
Hereford, UK