milters with postfix

[Glenn Steen]

On 26/06/07, Glenn Steen <glenn.steen at gmail.com> wrote:
> On 26/06/07, Nerijus Baliunas <nerijusb at dtiltas.lt> wrote:
> > On Tue, 26 Jun 2007 18:02:52 +0200 Glenn Steen <glenn.steen at gmail.com> wrote:
> >
> > > 2. Speedup for the normal, non-milter, case. If we haven't found any p
> > > records, skip the sometimes lengthy (depending on body size) spin
> > > through that we need when doing milters. Thus the normal case will
> > > become very close, in processing time, to how it was before the p
> > > record handling was introduced. This is actually a whooping 4 line
> > > thing:-).
> >
> > It's the following change, yes?
> >
> >  # Inelegant, but working. Instead of an efficient seek, we spinn through to
> > -# after X record. Unless we don't have a body to spin through.
> > -    if (!$message->{nobody}) {
> > +# after X record. Unless we don't have a body to spin through. Also skip
> > +# the spin if we don't have any p records already (to not punish the normal
> > +# case).
> > +    if (!$message->{nobody} || $pRecordsFound) {
> >
> > If I understand comment correctly, the last line should be
> > +    if (!$message->{nobody} && !$pRecordsFound) {
> > or am I mistaken?
> >
> > Regards,
> > Nerijus
> >
> Argh!
> Yes, well... You are right that it should be and, not or... But you
> don't need invert the $pRecordFound... We need a body to spin through,
> and we need have found p records, so it should be
> +    if (!$message->{nobody} && $pRecordsFound) {
> I really need that vacation:-). If my logic still is flawed, please
> somebody hit me over the head with it!
>
> Jules, will you need an amended patch for that?
>
Here's the amended patch. Jeez, five lines of code and I still manage
to mess it up. Sigh.

Cheers
-- 
-- Glenn
email: glenn < dot > steen < at > gmail < dot > com
work: glenn < dot > steen < at > ap1 < dot > se
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Postfix.pm.prec_wrec_speedup_fix.patch
Type: application/octet-stream
Size: 2569 bytes
Desc: not available
Url : http://lists.mailscanner.info/pipermail/mailscanner/attachments/20070626/ef832e3a/Postfix.pm.prec_wrec_speedup_fix.obj