Test::Harness, Test::Simple & bug in install.sh (4.6*.*)

[Quentin Campbell]

Julian

Since you added Test::Harness, Test::Simple, etc to the collection of source RPMs in 'install.sh', a number of us have been experiencing MailScanner build problems.

At the heart of this is the 'sort_bug.t' test failure in Test::Simple (Test-Simple-0.70-1). I accept that this flags a genuine problem but as the use of 'eq_set' is now deprecated the 'sort_bug.t' test can be safely ignored.

I did this by using CPAN and forcing the installation of Test-Simple-0.70-1 and Test-Harness-2.64-1 on my RedHat AS4 system. However when you re-run install.sh (from 4.61.7-*) it ignored these already installed versions and tries to reinstall them itself.

The reinstallation problem is linked to line 290 in install.sh where you do:

  PERL5LIB=`perl -V | grep site_perl | grep -v config_args | tr -d ' ' | tr '\n' ':'`

If you _do_not_ set PERL5LIB as above then "./CheckModuleVersion Test::Simple 0.70" works as expected and returns '0'. With PERL5LIB set as above then the above invocation of CheckModuleVersion returns '1' and causes the install.sh script to try to reinstall Test::Simple (which fails because of the sort_bug.t test failure).

I note that CheckModuleVersion also fails to find the already installed version of Test::Harness but it does correctly find most of the other modules you check for.

There appears to be a further problem in install.sh at lines 329 to 334: 
 322 FILEPREFIX=perl-${MODFILE}-${VERS}-${BUILD}
 ...
 329 if [ "x${MODFILE}" = "xCompress-Zlib" -o "x${MODFILE}" = "xTest-Harness" ]; then
 330   echo Detected Compress-Zlib, building appropriately...
 331   PERL5LIB= $RPMBUILD --rebuild ${FILEPREFIX}.src.rpm
 332 else
 333   $RPMBUILD --rebuild ${FILEPREFIX}.src.rpm
 334 fi

What is the purpose of line 331?  

PS After PERL5LIB is set at line 290 it contains (as an unbroken string):
 
/usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi:/usr/lib/perl5/site_perl/5.8.4/i386-linux-thread-multi:/usr/lib/perl5/site_perl/5.8.3/i386-linux-thread-multi:/usr/lib/perl5/site_perl/5.8.2/i386-linux-thread-multi:/usr/lib/perl5/site_perl/5.8.1/i386-linux-thread-multi:/usr/lib/perl5/site_perl/5.8.0/i386-linux-thread-multi:/usr/lib/perl5/site_perl/5.8.5:/usr/lib/perl5/site_perl/5.8.4:/usr/lib/perl5/site_perl/5.8.3:/usr/lib/perl5/site_perl/5.8.2:/usr/lib/perl5/site_perl/5.8.1:/usr/lib/perl5/site_perl/5.8.0:/usr/lib/perl5/site_perl:
  
Quentin
---
PHONE: +44 191 222 8209    Information Systems and Services (ISS),
                           Newcastle University,
                           Newcastle upon Tyne,
FAX:   +44 191 222 8765    United Kingdom, NE1 7RU.
------------------------------------------------------------------------