On 30/01/07, Julian Field <MailScanner at ecs.soton.ac.uk> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I just noticed a nasty obvious bug in KickMessage in Postfix.pm.
>
> Please find the "sub KickMessage" line in Postfix.pm and change the code
> to this:
>
> # Send an I down the FIFO to the Postfix queue manager, so that it reads
> # its incoming queue.
> # I am passed a hash of queues --> space-separated string of message ids
> sub KickMessage {
> my($queue2ids) = @_;
> my($queue);
>
> # Do a kick for every queue that contains some message ids
> foreach $queue (keys %$queue2ids) {
> next unless $queue2ids->{$queue};
>
> # Using the spool directory with the last element chopped off,
> # find the public directory wth the qmgr FIFO in it. Send an I
> # to that FIFO.
> my $public = $queue;
> $public =~ s/[^\/]+$/public/;
> next unless $public; # Sanity checking!
> my $fh = new FileHandle;
> $fh->open(">$public/qmgr") or
> MailScanner::Log::WarnLog("KickMessage failed as couldn't write
> to " .
> "%s, %s", "$public/qmgr", $!);
> print $fh "I";
> $fh->close;
> }
> return 0;
> }
>
> That stands rather more chance of working properly. But please do test
> this to ensure it works. If you remove the "Sanity checking!" line
> completely and then run it as you were before, you should not get any
> error message again. Let me know how you get on.
>
> Thanks!
>
> Jules.
>
Ah, that explains that:-).
Now running without a problem on my testbed, with the above twoline
fix as well as with my p record (still not 2.4 "kocher") thing;-)
--
-- Glenn
email: glenn < dot > steen < at > gmail < dot > com
work: glenn < dot > steen < at > ap1 < dot > se