Missing /rules files from MailScanner installation fromports

[James L. Day]

Drew,

The FreeBSD MailScanner port puts .sample files all over the place, but
I've never seen anything in the port to remove them...

The attached Makefile patch I whipped up should make the port install
and run with fewer errors...

>From /usr/ports/mail/mailscanner, type:

patch < /path/to/Makefile.diff

And yes, after running "make install" you must run "make
initial-config".  It would be nice if during a first-time install, the
port would perform "initial-config" automatically.  It could be
triggered by the lack of a "/usr/local/etc/MailScanner" directory or the
"MailScanner.conf" file, etc.

If I were the creator of a cool application such as MailScanner and a
port maintainer was causing public outcry, I'd be inclined to show him
the light.  I'm quite capable of making myself look bad; I don't need
any help...

As always, YMMV..  ;-)

Lynn

Drew Marshall wrote:
> On 7 Oct 2006, at 06:03, Michael S. wrote:
>
>> Finally somebody who has a clue!!
>
> I think that is a little harsh and along with the tone in your
> original e-mail you are about as likely to walk to the moon as to get
> this fixed.
>
>>
>> Thanks James for verifying this. Maybe the port Maintainer can
>> finally do
>> something about this after telling me I was crazy. See all the NOT SO
>> NICE
>> messages in past threads regarding this issue.
>
> I participated in the previous thread and I seem to remember that
> there were more people who had no problem than there were who had and
> although there was some attempt to help, you reacted with the same
> tone as you are now. No one owes you a working port. If you can't make
> it work or feel that Jan-Peter is doing a bad job then come forward
> and offer to help. I am sure he won't mind at all. He is a busy guy
> and this is open source. If you pay for it, expect it to work (I am
> sure you have many Microsoft products that do just that :-) ). If you
> are that concerned, drop Julian an e-mail and pay him to install it
> for you.
>
>>
>> Thank you.
>>
>> -----Original Message-----
>> From: mailscanner-bounces at lists.mailscanner.info
>> [mailto:mailscanner-bounces at lists.mailscanner.info] On Behalf Of
>> James L.
>> Day
>> Sent: Saturday, October 07, 2006 12:44 AM
>> To: MailScanner discussion
>> Subject: Re: FW: Missing /rules files from MailScanner installation
>> fromports
>>
>> I just did a clean install on my FreeBSD 5.5-STABLE machine. My comments
>> are within..
>>
>> Michael S. wrote:
>>>
>>> There is a problem with installing MailScanner 4.55.10-3 via ports. I
>>> reported this many months ago, still the same old problem.
>>>
>>> If you install MS on a server that has never had MS it starts
>>> complaining about the following files that it can't find.
>>>
>>> About 4 or so months ago when I reported this, the port maintainer
>>> tried to tell me my port system on my Freebsd box had a problem. Since
>>> then, we have purchased 4 additional Freebsd boxes that all exhibit
>>> the same installation issue, missing files after the install. If you
>>> don't believe me, try installing MS on a Freebsd server that has never
>>> had MS installed. The following list of files will be missing from
>>> your installation;
>>>
>>> /rules/bounce.rule
>>>
>>> /rules/max.message.size.rule
>>>
>>> /mcp/mcp.spam.assassin.prefs.conf
>>>
>> I agree..
>>
>> Oct 6 23:23:16 alms MailScanner[30703]: MailScanner E-Mail Virus Scanner
>> version 4.55.10 starting...
>> Oct 6 23:23:16 alms MailScanner[30703]: Could not read file
>> /usr/local/etc/MailScanner/mcp/mcp.spam.assassin.prefs.conf
>> Oct 6 23:23:16 alms MailScanner[30703]: Error in line 2027, file
>> "/usr/local/etc/MailScanner/mcp/mcp.spam.assassin.prefs.conf" for
>> mcpspamassassinprefsfile does not exist (or can not be read)
>> Oct 6 23:23:16 alms MailScanner[30703]: Cannot open ruleset file
>> /usr/local/etc/MailScanner/rules/bounce.rules, No such file or directory
>> Oct 6 23:23:16 alms MailScanner[30703]: Cannot open ruleset file
>> /usr/local/etc/MailScanner/rules/max.message.size.rules, No such file or
>> directory
>>
>> --- snip --
>
> Because I have run the port for several years, mine are upgrades so
> the original are always there so I have never noticed them missing.
> Are the files there as .sample files? I assume you ran the scripts at
> the end of the install to move the .sample files?
>
>>>
>>> Also, the follow files ARE NOT copied to /usr/local/etc/rc.d.
>>> According to the docs;
>>>
>>> The port installs two start/stop scripts in /usr/local/etc/rc.d:
>>>
>>> mailscanner.sh
>>>
>>> mta.sh
>>>
>> I disagree. They were created for me...
>>
>> -r-xr-xr-x 1 root wheel 1017 Oct 6 23:19 mailscanner.sh
>> -r-xr-xr-x 1 root wheel 4412 Oct 6 23:19 mta.sh
>
> And me every time I upgrade.
>
>>
>>> But this never happens. You have to go back to the port collections
>>> file directory and copy the shell script into the proper directory.
>>>
>>> Can you have the port maintainer correct this problem?
>
> The FreeBSD port is not maintained by Julian. You would be better
> asking (Nicely) Jan-Peter, who's e-mail address is in the Makefile in
> the ports tree or indeed as I have suggested else where do it yourself
> and offer to help him improve the current port.
>
> Regards
>
> Drew
> --MailScanner mailing list
> mailscanner at lists.mailscanner.info
> http://lists.mailscanner.info/mailman/listinfo/mailscanner
>
> Before posting, read http://wiki.mailscanner.info/posting
>
> Support MailScanner development - buy the book off the website!
-------------- next part --------------
--- Makefile	Sat Oct  7 08:52:32 2006
+++ Makefile.jld	Sat Oct  7 09:25:28 2006
@@ -112,6 +112,8 @@
 		spam.lists.conf virus.scanners.conf \
 		phishing.safe.sites.conf \
 		country.domains.conf
+RULES_FILES=	EXAMPLES README bounce.rules \
+		max.message.size.rules spam.whitelist.rules
 MCP_FILES=	mcp.spam.assassin.prefs.conf \
 		10_example.cf
 USRLOCAL_FILES_LIB=	\
@@ -236,10 +238,11 @@
 		${PREFIX}/etc/MailScanner/${FILE}.sample
 .endfor
 	${MKDIR} ${PREFIX}/etc/MailScanner/rules
-	cd ${WRKSRC}/etc/rules && \
-		${INSTALL_DATA} EXAMPLES README ${PREFIX}/etc/MailScanner/rules
-	${INSTALL_DATA} ${WRKSRC}/etc/rules/spam.whitelist.rules \
-		${PREFIX}/etc/MailScanner/rules/spam.whitelist.rules.sample
+	${CHMOD} ${BINMODE} ${PREFIX}/etc/MailScanner/rules
+.for FILE in ${RULES_FILES}
+	${INSTALL_DATA} ${WRKSRC}/etc/rules/${FILE} \
+		${PREFIX}/etc/MailScanner/rules/${FILE}.sample
+.endfor
 	${MKDIR} ${PREFIX}/etc/MailScanner/mcp
 	${CHMOD} ${BINMODE} ${PREFIX}/etc/MailScanner/mcp
 .for FILE in ${MCP_FILES}
@@ -351,8 +354,10 @@
 initial-config: renew-wrapper renew-autoupdate renew-reports
 	cd ${WRKSRC}/etc && ${INSTALL_DATA} ${ETC_FILES} \
 		${PREFIX}/etc/MailScanner
-	${INSTALL_DATA} ${WRKSRC}/etc/rules/spam.whitelist.rules \
-		${PREFIX}/etc/MailScanner/rules/spam.whitelist.rules
+	cd ${WRKSRC}/etc/rules && ${INSTALL_DATA} ${RULES_FILES} \
+		${PREFIX}/etc/MailScanner/rules
+	cd ${WRKSRC}/etc/mcp && ${INSTALL_DATA} ${MCP_FILES} \
+		${PREFIX}/etc/MailScanner/mcp
 	@${ECHO} "******************************************************************************"
 	@${ECHO} "The provided default configuration requires several directories to be created:"
 	@${ECHO} "/var/spool/MailScanner/incoming"