Beta 4.51.2: "Use TNEF Contents"

[Julian Field]

-----BEGIN PGP SIGNED MESSAGE-----

On 24 Feb 2006, at 16:19, Julian Field wrote:

> * PGP Signed: 02/24/06 at 16:19:43
>
> On 24 Feb 2006, at 15:38, Rick Cooper wrote:
>>
>>
>>> -----Original Message-----
>>> From: mailscanner-bounces at lists.mailscanner.info
>>> [mailto:mailscanner-bounces at lists.mailscanner.info]On Behalf Of  
>>> Julian
>>> Field
>>> Sent: Thursday, February 23, 2006 4:48 PM
>>> To: MailScanner discussion
>>> Subject: Re: Beta 4.51.2: "Use TNEF Contents"
>>>
>> [...]
>>
>> Julian,
>>
>> If you send a rich text message with no body and Use TNEF is set  
>> to replace,
>> MailScanner goes into a loop dying and restarting. I tracked the  
>> error down
>> to EximDiskStore.pm line 375. I am not sure what is what there but  
>> the debug
>> message is:
>>
>> read-open
>> /var/spool/mailscanner/incoming/16938/1FCdDL-0003Ai-DQ/ 
>> winmail.dat: No such
>> file or directory at /usr/lib/perl5/site_perl/5.8.0/MIME/Body.pm  
>> line 435
>>
>> Same with internal or external tnef parser. If you Change Use TNEF  
>> Contents
>> to add then it will pass. As it stands it would be fairly easy to DOS
>> MailScanner with an empty bodied rtf message.
>
> Well found, thankyou. This is why I have beta versions :-)
> Please try editing TNEF.pm (in /usr/lib/MailScanner/MailScanner).
> On line 275 you should see this:
> 	next if /^msg[\d-]+\.txt$/;
> Please try commenting out that line and try the test again.

And another change too:
In Message.pm around line 1680 there will be some code that says this:

   # Now try the same on all the parts
   my(@parts, $part, @keep);
   @parts = $entity->parts;
   foreach $part (@parts) {
     push @keep, $part unless DeleteEntity($message, $part, $tnef) == 1;
   }
   $entity->parts(\@keep);

After that, add this line:
   $entity->make_singlepart unless scalar(@keep);

and try again.

Hopefully both of these combined will help solve the problem.

If you can see if this fixes the problem, I'll put it out in a new  
beta this weekend.

- -- 
Julian Field
www.MailScanner.info
Buy the MailScanner book at www.MailScanner.info/store
PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654


-----BEGIN PGP SIGNATURE-----
Version: PGP Desktop 9.0.5 (Build 5050)

iQEVAwUBQ/83Kfw32o+k+q+hAQFn+Af+Nb5dNgq3hTkI2n3QrjwuC+XCFjBL9CiI
BIlWz8PEIXf2anVxsxD2YAhgjX+6Efuoa/I8juw6XoGg/0FYHpVy++i95uOoWN3H
dr0MjJSuXvCUBEYq7IiXS1g+QP/syJwgMS8fCdwQUcNpUk8W+AD89N7v1SJnZyC2
TuUK0oTqNsk0MmPX6zndsryBmiG1nuFZjZ/+9K0K6v7/fw6u5jVyOSm8lJtKd1LH
EAP/38TYEyNnUhMre0c1Nzc9Jw633ucg0Sj5IvELLwxZSB+it5qHKmgrkPmMc5dC
0USUUT/uFsjDpnB+RWB0mtzEmKJ5L+lpYP6uxhDi9T29BhaAtcBkLA==
=tXw+
-----END PGP SIGNATURE-----

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.