Sloppy error checking in MS code

[Rob Freeman]

If any of those problems happen, u have more troubles then MailScanner.
Personally, it is not MailScanners job to monitor a server for disk space,
permissions, or any other OS / HW problems.  And if someone is tampering
with permissions, well one has much more issues then getting mail at that
point.

-----Original Message-----
From: mailscanner-bounces at lists.mailscanner.info
[mailto:mailscanner-bounces at lists.mailscanner.info] On Behalf Of Mike
Jakubik
Sent: Saturday, December 16, 2006 3:10 PM
To: MailScanner discussion
Subject: Re: Sloppy error checking in MS code

Julian Field wrote:
> Ken,
> Thanks for backing me up. Yes, I don't check the return value of every 
> single call I make, but show me a programmer who does? (No doubt someone 
> will at this point). The most common point that is made is "what if the 
> system runs out of space" at this point, and all sorts of things will be 
> failing at this time, there isn't any need to create more errors at this 
> point, they just create noise. Yes, I quite happily admit I don't check 
> the result from everything I do. But if you want a practical piece of 
> software that runs at a reasonable speed.
>   

How much of a performance impact does a check for the return value of a 
system call produce? I believe what distinguishes good software from bad 
is how the software handles errors. What you are saying seems to 
contradict, as Matt Kettler stated that identical functions have error 
checking in the sendmail code, but not in postfix. No, i don't check to 
see if there is a floor when i wake up, but the chances of an I/O 
function failing because someone tampered with the directory/changed 
permissions/disk run out of space/some other OS/HW problem are MUCH 
greater than my floor disappearing. While i have not experienced any 
problems myself (AFAIK), it would at least shut up the postfix users/MS 
haters.

-- 
MailScanner mailing list
mailscanner at lists.mailscanner.info
http://lists.mailscanner.info/mailman/listinfo/mailscanner

Before posting, read http://wiki.mailscanner.info/posting

Support MailScanner development - buy the book off the website! 

-- 
No virus found in this incoming message.
Checked by AVG Free Edition.
Version: 7.5.432 / Virus Database: 268.15.21/589 - Release Date: 12/15/2006
5:10 PM
 

-- 
No virus found in this outgoing message.
Checked by AVG Free Edition.
Version: 7.5.432 / Virus Database: 268.15.21/589 - Release Date: 12/15/2006
5:10 PM