Possible problem with the new panda wrapper

[Rick Cooper]

Glenn,

I replied off list with more detail than here, I didn't notice your message
went to the
list as well as me.

> -----Original Message-----
> From: MailScanner mailing list [mailto:MAILSCANNER at JISCMAIL.AC.UK]On
> Behalf Of Steen, Glenn
> Sent: Tuesday, June 07, 2005 8:47 AM
> To: MAILSCANNER at JISCMAIL.AC.UK
> Subject: Possible problem with the new panda wrapper
>
>
> Hi Rick & all,
>
> I finally had a slow moment to look at your new wrapper script.
> Lets start out positive: I really like what you've done there. Might
> be because of the rich comments in a language I actually understand:-),
> but more likely the nice "sidestep" of terminal issues. Probably
> comes from you being a real programmer, where I'm just a know-nothing
> programmer-turned-sysadmin (happened just after the dark ages too:-):).
>
> Some "problems" though:
> Am I correct in that this still will not honour the path given at the
> end of options? So that saying "." or "./<message-id>" is virtually the
> same? Seems to me that MS could do that in ScanBatch, if TryCommercial
> times out (please correct me if I'm wrong!).
>
> Am I correct that you call pavcl once/directory, not once/batch? Would
> be nice if it was once/batch:).

Done, you should already have a copy of a new version of panda-wrapper, and
the required patch to SweepViruses.pm, to try out. Please let me/us know if
it's more like what you desire. It will scan the child's entire batch with
one call to pavcl

>
> Now for the real problem. When I simulate a batch of more than one
> message, this detects the "clean second" as the "unclean first". Better
> that I show what I mean:
[..]

This was a stupid error on my part. I deleted some debug stuff before
sending the last version to Julian and I didn't test it with a batch... I
deleted one line too many. I have attached a patch for panda-wrapper that
will fix this one line brain spaz.

Apply the patch or change the following line in panda-wrapper from:
  sub scan_virus{
to:

	sub scan_virus{
		# Make sure our Virtual Screen is clean when called.
		$VirtualScreens = "";

I don't know if/when Julian will incorporate the changes to panda-wrapper
and SweepViruses.pm to allow a single call to pavcl for each batch rather
than each message. If anyone else wants this change now/soon let me know and
I can send it to you or post it here.

Again, Sorry for the brain fade on the above error

Rick

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.



------------------------ MailScanner list ------------------------
To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
'leave mailscanner' in the body of the email.
Before posting, read the Wiki (http://wiki.mailscanner.info/) and
the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).

Support MailScanner development - buy the book off the website!

    [ Part 2, Application/OCTET-STREAM (Name: "panda-wrapper.diff")  ]
    [ 430bytes. ]
    [ Unable to print this part. ]