quarantine report running amok

[Jeff A. Earickson]

Julian,
    Yes, it looks like it worked.  Many thanks.

Jeff Earickson
Colby College

On Fri, 8 Apr 2005, Julian Field wrote:

> Date: Fri, 8 Apr 2005 16:53:01 +0100
> From: Julian Field <MailScanner at ECS.SOTON.AC.UK>
> Reply-To: MailScanner mailing list <MAILSCANNER at JISCMAIL.AC.UK>
> To: MAILSCANNER at JISCMAIL.AC.UK
> Subject: Re: quarantine report running amok
>
> Did the patch work? I'm off very soon and won't be back online much till
> tomorrow.
>
> Julian Field wrote:
>
>> This is possible. Here is a patch for Message.pm to clean up the output:
>> -----SNIP-----
>> --- Message.pm.old 2005-04-08 14:33:30.000000000 +0100
>> +++ Message.pm  2005-04-08 15:03:20.940680796 +0100
>> @@ -3872,12 +3872,18 @@
>>   my $from = $this->{from};
>>   #my $to   = join(', ', @{$this->{to}});
>>   my $subj = $this->{subject};
>> +  my $ip   = $this->{clientip};
>>   my $rept = join("    $reportword: ", @everyrept);
>> +  #print STDERR "Rept is\n$rept\n";
>> +
>> +  # Build list of unique archive and quarantine storage locations
>>   my @quarantines = grep /\//, @{$this->{archiveplaces}};
>>   push @quarantines, grep /\//, @{$this->{quarantineplaces}};
>> -  my $quarantine = join(", ", @quarantines);
>> -  my $ip   = $this->{clientip};
>> -  #print STDERR "Rept is\n$rept\n";
>> +  my($quarantine, %quarantinelist);
>> +  foreach $quarantine (@quarantines) {
>> +    $quarantinelist{$quarantine} = 1;
>> +  }
>> +  $quarantine = join(', ', sort keys %quarantinelist);
>>
>>   # Build unique list of recipients. Avoids Postfix problem which has
>>   # separate lists of real recipients and original recipients.
>> -----SNIP-----
>>
>> Please give this a try and let me know how you get on.
>>
>> Jeff A. Earickson wrote:
>>
>>> Julian,
>>>
>>> MS 4.40.11, Solaris 9.  I found this in my daily report of quarantined
>>> stuff.  The push @quarantines in CreatePostmasterNotice() seems to have
>>> run amok here.  Any idea why it would push the same string so many
>>> times?
>>>
>>> j37L9Nr5007705: 137.146.156.144 (xxx at colby.edu)
>>> quarantine: /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanner/quarantine/20050407/j37L9Nr5007705,
>>> /var/spool/MailScanne!
>>> MailScanner: Executable DOS/Windows programs are dangerous in email
>>> (SETUP.EXE)
>>>
>>> Jeff Earickson
>>> Colby College
>>>
>>> ------------------------ MailScanner list ------------------------
>>> To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
>>> 'leave mailscanner' in the body of the email.
>>> Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
>>> the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).
>>>
>>> Support MailScanner development - buy the book off the website!
>>
>>
>>
>> --
>> Julian Field
>> www.MailScanner.info
>> MailScanner thanks transtec Computers for their support
>> Buy the MailScanner book at www.MailScanner.info/store
>>
>> PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654
>>
>> ------------------------ MailScanner list ------------------------
>> To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
>> 'leave mailscanner' in the body of the email.
>> Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
>> the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).
>>
>> Support MailScanner development - buy the book off the website!
>>
>
> --
> Julian Field
> www.MailScanner.info
> MailScanner thanks transtec Computers for their support
> Buy the MailScanner book at www.MailScanner.info/store
>
> PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654
>
> ------------------------ MailScanner list ------------------------
> To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
> 'leave mailscanner' in the body of the email.
> Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
> the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).
>
> Support MailScanner development - buy the book off the website!
>

------------------------ MailScanner list ------------------------
To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
'leave mailscanner' in the body of the email.
Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).

Support MailScanner development - buy the book off the website!