MCP Messages vanishing

[Kristian Shaw]

Hello,

For some time I've noticed that messages that are both MCP and Spam
disappear into a black hole on two slackware systems. For me, this occurs
when the MCP action is 'forward xxx at xxx.xxx' and the spam action is
'attachment deliver'. In my logs the action just comes out as 'attachment'
with no deliver or forward actions. Messages that are either MCP or Spam are
delivered as I would expect.

I've found an area of code in MCPMessage.pm that I think handles the
delivery/forward logic and added some code where I don't think it was
handling forwarding. I have attached a patch for 4.33.3 at the end of this
email. (Hopefully I did it right as I've not made a patch before)

I've only tested this code for my system so I don't know if it breaks any
other combinations of spam/mcp actions. If I've misinterpreted how the code
works please let me know so I can put it right!

Thanks,

Kris.


MCPMessage.pm   2004-05-22 13:12:49.000000000 +0100
+++ ./MCPMessage.pm     2004-09-12 22:23:41.000000000 +0100
@@ -304,6 +304,14 @@
       $global::MS->{mta}->DeleteRecipients($this);
       $this->{mcpdelivering} = 0;
     }
+
+    # Added by KLS to deliver from MCP when forwarding and spam
+    # action is attachment
+    if ($actions{'forward'}) {
+      $this->{mcpdelivering} = 1;
+    }
+    # End of code by KLS
+
     # Message still exists, so it will be delivered to its new recipients
   } else {
     #

------------------------ MailScanner list ------------------------
To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
'leave mailscanner' in the body of the email.
Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).