MajorSophos

[John Rudd]

(not sure if the author wants this sent to the mailscanner list, or to
him directly, sorry if this was the wrong choice)


MajorSophos uses mktemp for the TMPDIR initialization, but mktemp isn't
very portable (at least not to Solaris 8).  Here's what I did:

around line 99-101, I changed:

          TMPDIR=`mktemp -d -q /tmp/$BASE.XXXXXX`

to:

          TMPDIR="/tmp/$BASE.$$"
          mkdir -m 700 $TMPDIR


($$ is "unique enough", considering the directory is short-lived, and
process numbers are unique)


Also, for the opening variables, it might be nice to have standard
alternate variables in comments.  Like this (though, for your std.
distribution, you might want to reverse which ones I have commented vs
uncommented):

# Program to run to install Sophos after downloading it.
# This is the script provided with MailScanner,
# not the script provided with Sophos.
#INSTALL=/usr/sbin/Sophos.install
INSTALL=/opt/MailScanner/bin/Sophos.install


# --------Sophos version reporting--------------------------------
# Set the location of the MailScanner wrapper for Sophos sweep.
# This is only used to report the Sophos version.  If it is wrong,
# it won't prevent the successful download or installation.
#WRAP=/usr/lib/MailScanner/sophos-wrapper
WRAP=/opt/MailScanner/lib/sophos-wrapper

# Set the directory name where Sophos is installed. This is only
# used for version reporting, it doesn't affect where the new
# version will be installed.
#SOPHOSDIR=/usr/local/Sophos
SOPHOSDIR=/opt/sophos



Otherwise, great script!  Thank you!

------------------------ MailScanner list ------------------------
To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
'leave mailscanner' in the body of the email.
Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).