FW: Bug in MCP & SA.pm patches to MS 4.34.8-1

[Quentin Campbell]

Julian

Sorry to have taken so long to get back to you on this but there is a
problem with both MCP.pm.patch and SA.pm.patch. Running MS (4.34.8-1) in
debug mode gives:

[root at cheviot4 MailScanner]# service MailScanner start
Starting MailScanner daemons:
         incoming sendmail:                                [  OK  ]
         outgoing sendmail:                                [  OK  ]
         MailScanner:       In Debugging mode, not forking...
SA bayes lock is /root/.spamassassin/bayes.lock
Bayes lock is at /root/.spamassassin/bayes.lock
Undefined subroutine &MailScanner::Conf::Value called at
/usr/lib/MailScanner/MailScanner/MCP.pm line 230, <GEN181> line 33.

When you restore the original MCP.pm code the same problem then appears
with SA.pm thus:

[root at cheviot4 mqueue.in]# service MailScanner start
Starting MailScanner daemons:
         incoming sendmail:                                [  OK  ]
         outgoing sendmail:                                [  OK  ]
         MailScanner:       In Debugging mode, not forking...
SA bayes lock is /root/.spamassassin/bayes.lock
Bayes lock is at /root/.spamassassin/bayes.lock
Undefined subroutine &MailScanner::Conf::Value called at
/usr/lib/MailScanner/MailScanner/SA.pm line 331.

Quentin
---
PHONE: +44 191 222 8209    Information Systems and Services (ISS),
                           University of Newcastle,
                           Newcastle upon Tyne,
FAX:   +44 191 222 8765    United Kingdom, NE1 7RU.
------------------------------------------------------------------------
"Any opinion expressed above is mine. The University can get its own."  

>-----Original Message-----
>From: MailScanner mailing list 
>[mailto:MAILSCANNER at JISCMAIL.AC.UK] On Behalf Of Julian Field
>Sent: 08 October 2004 14:03
>To: MAILSCANNER at JISCMAIL.AC.UK
>Subject: Re: Bug in SA.pm patch to MS 4.34.8-1
>
>Try the attached patches for SA.pm and MCP.pm.
>
>At 12:21 08/10/2004, you wrote:
>>Yes, using the existing "Envelope From Header" value seems the
>>appropriate thing to do.
>>
>>It also meets my requirement (see earlier posting) for a site 
>to be able
>>to specify a locally unique X-header string to use for the 
>envelope-from
>>address that MS can stuff into the message.
>>
>>Without that uniqueness I think SA will get confused when it tries to
>>decide which of the X-MailScanner-From: lines, all but one added by
>>upstream relays, it should use as the value of the pseudo-header
>>"EnvelopeFrom".
>>
>>The SA options document makes a comment that MTAs should avoid using a
>>single, standard, line containing the envelope-from address.
>>
>>When the amended patch is ready I will test it for you.
>>
>>Thanks
>>
>>Quentin
>>
>> >-----Original Message-----
>> >From: MailScanner mailing list
>> >[mailto:MAILSCANNER at JISCMAIL.AC.UK] On Behalf Of Julian Field
>> >Sent: 08 October 2004 11:57
>> >To: MAILSCANNER at JISCMAIL.AC.UK
>> >Subject: Re: Bug in SA.pm patch to MS 4.34.8-1
>> >
>> >At 11:52 08/10/2004, you wrote:
>> >>Julian
>> >>
>> >>The "EnvelopeFrom" pseudo-header may be working for you 
>and with SPF.
>> >>
>> >>It is not working here unless SA.pm and MCP.pm are patched as I
>> >>described earlier. :-(
>> >
>> >How about I add the
>> >"Envelope From Header"
>> >as defined in MailScanner.conf? That would save yet another
>> >config option.
>> >
>> >
>> >>I need this feature to work because I want to define rules 
>in MCP that
>> >>will allow me to discard messages to certain local addresses if the
>> >>envelope-from address is not from our two domains, ncl.ac.uk or
>> >>newcastle.ac.uk.
>> >
>> >--
>> >Julian Field
>> >www.MailScanner.info
>> >MailScanner thanks transtec Computers for their support
>> >Buy the MailScanner book at www.MailScanner.info/store
>> >
>> >PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654
>> >
>> >------------------------ MailScanner list ------------------------
>> >To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
>> >'leave mailscanner' in the body of the email.
>> >Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
>> >the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).
>> >
>> >
>>
>>------------------------ MailScanner list ------------------------
>>To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
>>'leave mailscanner' in the body of the email.
>>Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
>>the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).
>
>------------------------ MailScanner list ------------------------
>To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
>'leave mailscanner' in the body of the email.
>Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
>the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).
>

------------------------ MailScanner list ------------------------
To unsubscribe, email jiscmail at jiscmail.ac.uk with the words:
'leave mailscanner' in the body of the email.
Before posting, read the MAQ (http://www.mailscanner.biz/maq/) and
the archives (http://www.jiscmail.ac.uk/lists/mailscanner.html).