MS 4.30.3 can't count??

[Jeff A. Earickson]

Julian,
   Patch in place, monitoring the syslogs, stay tuned.  Jeff

On Wed, 5 May 2004, Julian Field wrote:

> Date: Wed, 5 May 2004 10:07:51 +0100
> From: Julian Field <mailscanner at ECS.SOTON.AC.UK>
> Reply-To: MailScanner mailing list <MAILSCANNER at JISCMAIL.AC.UK>
> To: MAILSCANNER at JISCMAIL.AC.UK
> Subject: Re: MS 4.30.3 can't count??
>
> Can you try this patch to SA.pm please:
>
> -----SNIP-----
> --- SA.pm.old   2004-05-05 10:11:37.000000000 +0100
> +++ SA.pm       2004-05-05 10:12:10.000000000 +0100
> @@ -469,6 +469,7 @@
>       # Roll the queue along one
>       $SAsuccessqsum += (shift @SAsuccessqueue)?1:-1
>             if @SAsuccessqueue>$queuelength;
> +    $SAsuccessqsum = 0 if $SAsuccessqsum<0;
>     };
>     alarm 0;
>     # Workaround for bug in perl shipped with Solaris 9,
> @@ -510,6 +511,7 @@
>         # Roll the queue along one
>         $SAsuccessqsum += (shift @SAsuccessqueue)?1:-1
>           if @SAsuccessqueue>$queuelength;
> +      $SAsuccessqsum = 0 if $SAsuccessqsum<0;
>
>         if ($SAsuccessqsum>$maxfailures && @SAsuccessqueue>=$queuelength) {
>           MailScanner::Log::WarnLog("SpamAssassin timed out (with no network" .
> -----SNIP-----
>
> If that fixes it, I'll apply it to the RBL checking counter code as well.
>
> At 03:34 05/05/2004, you wrote:
> >Julian,
> >    I upgraded to 4.30.3 this morning, and later on noticed in
> >my syslogs:
> >
> >SpamAssassin timed out and was killed, failure -156 of 20
> >
> >with random negative numbers in there.  Later on, probably
> >after a four-hour restart, it started counting correctly
> >again.  Maybe a counter isn't initialized at startup?
> >(Setup: MS 4.303, SA 2.63, Sol 9, Sun V1280, razor, perl 5.8.3,
> >threaded)
> >
> >Jeff Earickson
> >Colby College
> >
> >-------------------------- MailScanner list ----------------------
> >To leave, send    leave mailscanner    to jiscmail at jiscmail.ac.uk
> >Before posting, please see the Most Asked Questions at
> >http://www.mailscanner.biz/maq/     and the archives at
> >http://www.jiscmail.ac.uk/lists/mailscanner.html
>
> --
> Julian Field
> www.MailScanner.info
> MailScanner thanks transtec Computers for their support
>
> PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654
>
> -------------------------- MailScanner list ----------------------
> To leave, send    leave mailscanner    to jiscmail at jiscmail.ac.uk
> Before posting, please see the Most Asked Questions at
> http://www.mailscanner.biz/maq/     and the archives at
> http://www.jiscmail.ac.uk/lists/mailscanner.html
>

-------------------------- MailScanner list ----------------------
To leave, send    leave mailscanner    to jiscmail at jiscmail.ac.uk
Before posting, please see the Most Asked Questions at
http://www.mailscanner.biz/maq/     and the archives at
http://www.jiscmail.ac.uk/lists/mailscanner.html