sendmail patch for split recipients - ( was Re: ANNOUNCE: Unstable 4.30.1)

[Julian Field]

Well spotted. Absolutely correct.

At 08:50 15/04/2004, you wrote:
>Seems to work fine for me.
>Maybe there's a typo I changed this
>+  unless (open($this->{dhandle}, '+<' . $this->{dpath})) {
>into this
>+  unless (open($this->{indhandle}, '+<' . $this->{dpath})) {
>
>----- Original Message -----
>From: "Ken Anderson (Pacific Internet)" <ka at PACIFIC.NET>
>To: <MAILSCANNER at JISCMAIL.AC.UK>
>Sent: Thursday, April 15, 2004 2:00 AM
>Subject: sendmail patch for split recipients - ( was Re: ANNOUNCE: Unstable
>4.30.1)
>
>
> > oops! Spoke too soon again...
> > The patch causes problems for SpamAssassin. In particular, DCC seems to
> > complain of 'missing message body' for every message test & nothing gets
> > the DCC score.
> >
> > Ken A
> > Pacific.Net
> >
> >
> > Julian Field wrote:
> >
> > > At 17:47 14/04/2004, you wrote:
> > >
> > >> The splitted messages thing was about using instead of exlusive lock
> > >> on df
> > >> files because they were hard links of the same file in case of split,
> > >
> > >
> > > Please try this patch to SMDiskStore.pm
> > >
> > > -----SNIP-----
> > > --- SMDiskStore.pm.old  2004-04-14 18:31:57.000000000 +0100
> > > +++ SMDiskStore.pm      2004-04-14 18:32:00.000000000 +0100
> > > @@ -123,8 +123,9 @@
> > >    #print STDERR "Got hlock\n";
> > >
> > >    # If locking the dfile fails, then must close and unlock the qffile
>too
> > > -  unless (MailScanner::Lock::openlock($this->{indhandle},
> > > -                      '+<' . $this->{dpath}, 'w', 'quiet')) {
> > > +  #JKF unless (MailScanner::Lock::openlock($this->{indhandle},
> > > +  #JKF                     '+<' . $this->{dpath}, 'w', 'quiet')) {
> > > +  unless (open($this->{dhandle}, '+<' . $this->{dpath})) {
> > >      MailScanner::Lock::unlockclose($this->{inhhandle});
> > >      return undef;
> > >    }
> > > @@ -138,7 +139,8 @@
> > >  sub Unlock {
> > >    my $this = shift;
> > >
> > > -  MailScanner::Lock::unlockclose($this->{indhandle});
> > > +  #JKF MailScanner::Lock::unlockclose($this->{indhandle});
> > > +  close($this->{indhandle});
> > >    MailScanner::Lock::unlockclose($this->{inhhandle});
> > >  }
> > >
> > > -----SNIP-----
> > >
>
>+----------------------------------------------------------+
>| Dr. Francesco Rotondo         E-mail: f.rotondo at teseo.it |
>+----------------------------------------------------------+
>| Teseo Internet Provider, Srl                             |
>| C.so A. De Gasperi, 344       Web: http://www.teseo.it   |
>| 70125 - Bari                  Tel: +39(080)5036970       |
>| Italy                         Fax: +39(080)5008672       |
>+----------------------------------------------------------+

--
Julian Field
www.MailScanner.info
MailScanner thanks transtec Computers for their support

PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654