New feature request

[Julian Field]

The permissions are all set using umask, which should be a lot quicker
(setting the umask doesn't involve any extra disk writes). In perl the
chown and chgrp are done with 1 combined call. And it only makes the call
if it actually needs to. If you leave the settings at their default values
then there are no extra calls made at all.

As most people will only want to set
         Incoming Work Permissions (umask so no extra writes)
         Quarantine User & Group (only 1 call per quarantined file)
         Quarantine Permissions (umask so no extra writes)
you are only creating 1 extra write per quarantined file, and no overhead
on the temporary files at all, which is where the speed really counts.

With all these chown/chgrp calls, the first thing MailScanner does is to
try them on a real test file to see which settings actually work, as things
like chown probably won't work if you're not root and all sorts of
OS-specific rules like that. From then on, it only attempts to make changes
that it knows will actually work.

At 21:13 07/11/2003, you wrote:
>I missed some of this thread. Is it done by chmod/chown-ing every single
>file? If it is, is there a noticeable performance hit?
>
>/Peter Bonivart
>
>--Unix lovers do it in the Sun
>
>Sun Fire V210, Solaris 9, Sendmail 8.12.10, MailScanner 4.23-11,
>SpamAssassin 2.60 + DCC 1.2.9, ClamAV 20030829
>
>Julian Field wrote:
>>Okay, it's all done and released. You have 6 shiny new settings to play
>>with.
>>
>>Download as usual from
>>         www.mailscanner.info
>>--
>>Julian Field
>>www.MailScanner.info
>>MailScanner thanks transtec Computers for their support
>>
>>PGP footprint: EE81 D763 3DB0 0BFD E1DC  7222 11F6 5947 1415 B654

--
Julian Field
www.MailScanner.info
Professional Support Services at www.MailScanner.biz
MailScanner thanks transtec Computers for their support
PGP footprint: EE81 D763 3DB0 0BFD E1DC  7222 11F6 5947 1415 B654