4.20-3 Re: MS, postfix, and MIME attachments

[Julian Field]

I have just posted version 4.20-3 including this bugfix for Postfix and 
ZMailer. It's quite an important fix, as without it you might not deliver 
mail you are quarantining or archiving. You won't *lose* any mail, but the 
recipients may not receive it.

The change does not affect sendmail or Exim users at all, only Postfix and 
ZMailer.

At 23:44 02/05/2003, Mariano Absatz wrote:
>OK... my wife will kill me for coming home late again on a Friday evening...
>but the patch is working just fine...
>
>Delivers the mail and stores in the quarantine directory when told to do
>both...
>
>If you release during the weekend you can apply it confidently.
>
>BTW, it's just a silly thing, but the release has a bunch of cvs temporary
>files scattered:
>./docs/.#ChangeLog.1.145.2.55
>./docs/.#ChangeLog.1.145.2.69
>./bin/.#mailscanner.1.142.2.27
>./lib/MailScanner/.#SweepViruses.pm.1.49.2.14
>
>and lots of executable files:
>etc/*.conf
>etc/reports/cy+en/*
>lib/MailScanner/*.pm
>
>and there's also a lib/MailScanner/RBLs.pm.old lying there since some
>releases ago...
>
>Regards.
>
>El 2 May 2003 a las 21:54, Julian Field escribió:
>
> > As I haven't got a ZMailer system to test it on, can you drop me a line
> > (off-list) once you've tested it?
> > Thanks!
> >
> > At 20:04 02/05/2003, you wrote:
> > >El 2 May 2003 a las 17:14, Julian Field escribió:
> > >
> > > > >
> > > > >I will continue investigating in and around CopyEntireMessage.
> > > >
> > > > Fixed in 4.20-2.
> > > >
> > > > Mariano --- You might want to check the CopyEntireMessage function 
> in your
> > > > ZMailer code. I think it suffers the same problem.
> > >
> > >Indeed... since in this case, apparently Postfix code inherited our 
> ZMailer
> > >mistakes :-)
> > >
> > >I won't have time to test this until Monday, but this patch (which simply
> > >copies your code) should do, since it is calling already working 
> functions...
> > >
> > >*** ZMDiskStore.pm.old  Tue Apr 22 16:32:32 2003
> > >--- ZMDiskStore.pm      Fri May  2 15:48:20 2003
> > >***************
> > >*** 321,331 ****
> > >     my $this = shift;
> > >     my($message, $targetdir, $targetfile) = @_;
> > >
> > >!   my $hdfile = $this->{hdpath};
> > >
> > >!   #system($global::cp . " \"$hdfile\" \"$targetdir/$$this{tname}\"");
> > >!   rename("$hdfile", "$targetdir/$$this{hdname}");
> > >!   #my
> > >$hdoutpath=MailScanner::Sendmail::HDOutFileName($targetdir/$$this{tname});
> > >   }
> > >
> > >
> > >--- 321,345 ----
> > >     my $this = shift;
> > >     my($message, $targetdir, $targetfile) = @_;
> > >
> > >!   #my $hdfile = $this->{hdpath};
> > >!   #rename("$hdfile", "$targetdir/$$this{hdname}");
> > >
> > >! # BBY we were moving instead of copying... now we copy(cat)
> > >! # BBY Julian's higher level solution that is much clearer
> > >! # BBY and storeentireasdfqf means "include envelope" which
> > >! # BBY is quite reasonable
> > >!
> > >!   #print STDERR "Copying to $targetdir $targetfile\n";
> > >!   if (MailScanner::Config::Value('storeentireasdfqf')) {
> > >!     #print STDERR "Copying to dir $targetdir\n";
> > >!     $this->CopyToDir($targetdir);
> > >!   } else {
> > >!     #print STDERR "Copying to file $targetdir/$targetfile\n";
> > >!     my $target = new IO::File "$targetdir/$targetfile", "w";
> > >!     MailScanner::Log::WarnLog("writing to $targetdir/$targetfile: $!")
> > >!       if not defined $target;
> > >!     $this->WriteEntireMessage($message, $target);
> > >!   }
> > >   }
> > >
>
>--
>Mariano Absatz
>El Baby
>----------------------------------------------------------
>Question: If someone with multiple personalities tries
>to commit suicide, do the police consider it a hostage
>situation?

-- 
Julian Field
www.MailScanner.info
Professional Support Services at www.MailScanner.biz
MailScanner thanks transtec Computers for their support