useless use of private variable in void context at CustomConfig.p m line 475...?

Julian Field mailscanner at ecs.soton.ac.uk
Mon Aug 11 21:39:48 IST 2003


Well spotted. It should be "||" and not "or".

At 21:23 11/08/2003, you wrote:
>If I do:
>
>perl -cw CustomConfig.pm
>
>...then I get:
>private variable in void context at CustomConfig.pm2 line 475.
>
>The line numbers may have changed a little bit, but here's the tidbit of
>code in question:
>     # Use the sanitised filename to avoid problems caused by people forcing
>     # logging of attachment filenames which contain nasty SQL instructions.
>     $file = $message->{file2safefile}{$file} or $file;
>
>Looking at that though I'm not sure whether it's really a problem or not.
>So... any MS+Perl guru care to say whether that is something that needs
>fixing?  I just adapted the SQLLogging code to work with flat files instead
>(not enough spare mem on the test system to run mysqld :-( ) and inherited
>this line in the process.
>
>--
>Trever

--
Julian Field
www.MailScanner.info
Professional Support Services at www.MailScanner.biz
MailScanner thanks transtec Computers for their support



More information about the MailScanner mailing list