Mailscanner Spam Whitelisting

[Julian Field]

At 18:10 27/07/2002, you wrote:
>Well I can take it out and the message will still get tagged so
>technically you are supporting your code.  If you aren't using this then
>wouldn't it be wise to remove it to speed SA calls up then because
>$SAResult = ($spamness->is_spam())?1:0; is in sender.pl and is occurring
>even if $SAResult isn't being used for anything.

You're right, there is 1 line of redundant code. If there's only 1 in 6,500
I'll be surprised :)

>Regardless of all that, if an address is in the whitelist, should
>SAForkAndTest even be called?  That's the point of the issue.  If it is
>getting called for even whitelistings, then wouldn't it be better not
>todo that to speed things up.  If it's not supposed to get called for a
>whitelisting, then why is it.  This is the 3.22.7 code.

Because of the "if" statement:
    if ($Info ne "" && $Config::SpamAssassin && (!$IsOnWhiteList ||
$Config::IncludeSpamHeader))
which I hope answers your question.
It is called, even though it is whitelisted, *if* the mailscanner.conf file
is set to always include the SpamAssassin header.

>-----Original Message-----
>From: Julian Field [mailto:mailscanner at ECS.SOTON.AC.UK]
>Sent: Saturday, July 27, 2002 12:34 PM
>To: MAILSCANNER at JISCMAIL.AC.UK
>Subject: Re: Mailscanner Spam Whitelisting
>
>
>At 17:27 27/07/2002, you wrote:
> >I see the confusion but this is a report file.  In sender.pl, I have
> >some extra code
>
>So now I'm supporting your code, not mine? That's novel...
>
> >  that if $SaResult is true, I then get the score and if
> >its < 30 then I get the whole rewite ($spamness->rewrite_mail ()) and
> >send that to a file called spr$mID.  I do this so I can watch for false
>
> >positives and report to razor.
> >
> >The output that you are seeing is from that code which only runs if
> >  $SAResult = ($spamness->is_spam())?1:0; is true
>
>And if you study my code, you'll discover that I don't use is_spam().
>There's a reason: it's very unreliable.
>
> >It shouldn't be true if the message has a trigger that's whitelisted
> >though correct?  Or are you running everything thru SA and then
> >checking the whitelist?
> >
> >-----Original Message-----
> >From: Julian Field [mailto:mailscanner at ECS.SOTON.AC.UK]
> >Sent: Saturday, July 27, 2002 10:28 AM
> >To: MAILSCANNER at JISCMAIL.AC.UK
> >Subject: Re: Mailscanner Spam Whitelisting
> >
> >
> >At 14:59 27/07/2002, you wrote:
> > >Where do you see that?  I'm running SA from Mailscanner.
> >
> >These are all created by SA running from something other than
> >MailScanner. If it's not you running it this way, then someone in the
> >path from the sender to you must be running it this way.
> >
> > > >Subject: *****SPAM***** CBSMW After The Bell Report: Senate
> > > >confirms
> > >SEC
> > > >nominees
> > > >X-DCC-servers-Metrics: eeyore 1049; Body=1 Fuz1=2 Fuz2=2
> > > >X-Spam-Status: Yes, hits=9.2 required=5.0
> > > >
> > >tests=FWD_MSG,INVALID_DATE,FORGED_RCVD_FOUND,COPYRIGHT_CLAIMED,
> > > >               OPT_IN,CLICK_BELOW,ONLY_COST,LINES_OF_YELLING,
> > > >               HTML_WITH_BGCOLOR,CLICK_HERE_LINK,MIME_LONG_LINE_QP,
> > > >               WEIRD_PORT,CTYPE_JUST_HTML,MSG_ID_ADDED_BY_MTA_2,
> > > >               MISSING_MIMEOLE,MISSING_OUTLOOK_NAME,AWL
> > > >         version=2.40
> > > >X-Spam-Flag: YES
> > > >X-Spam-Level: *********
> > > >X-Spam-Checker-Version: SpamAssassin 2.40 (devel $Id:
> > > >SpamAssassin.pm,v 1.102 2002/07/18 15:18:39 jmason Exp $)
> > > >X-Spam-Prev-Content-Type: text/html
> > > >X-Spam-Prev-Content-Transfer-Encoding: quoted-printable
> >
> >--
> >Julian Field                Teaching Systems Manager
> >jkf at ecs.soton.ac.uk         Dept. of Electronics & Computer Science
> >Tel. 023 8059 2817          University of Southampton
> >                              Southampton SO17 1BJ
>
>--
>Julian Field                Teaching Systems Manager
>jkf at ecs.soton.ac.uk         Dept. of Electronics & Computer Science
>Tel. 023 8059 2817          University of Southampton
>                              Southampton SO17 1BJ

--
Julian Field                Teaching Systems Manager
jkf at ecs.soton.ac.uk         Dept. of Electronics & Computer Science
Tel. 023 8059 2817          University of Southampton
                             Southampton SO17 1BJ