Sys::Syslog Bug Report

[Julian Field]

Well spotted. I had misread the spec of the parameters to Sys::Syslog.

Attached are 2 files:
1. all_bin.patch.gz contains a single file of all the patches combined.
With something along the lines of
         cd /usr/local/MailScanner/bin
         gunzip all_bin.patch.gz
         patch -p0 < all_bin.patch
    you should be able to make it work (try with "-p" if "-p0" doesn't work).

2. separate_patches.tar.gz is a gzipped tar file of all the patches, with 1
patch per file. You will need to apply these patches one at a time, which
is obviously more work than method 1, but will work if your "patch" command
cannot work with multiple patches in one file.

I haven't had a chance to test these patches very thoroughly, so any
reports of success/failure would be useful.

I'll probably release a new version containing these patches at the start
of next week once I've done some more testing. But if you can try it out in
the mean time, I would be very grateful.

At 19:44 23/08/2002, JWSmythe wrote:
>         Last night at about 5am, our mail server stopped delivering mail.
>Everything was being stored in my mqueue.in , but not being processed further.
>         Every time mailscanner started, this error would pop up in my
> logs, and
>on console.
>
>Aug 23 13:45:05 mail mailscanner[8807]: Commercial virus checker failed
>with real error: Modification of a read-only value attempted at
>/usr/lib/perl5/5.8.0/i686-linux/Sys/Syslog.pm line 296, <KID> line 2.
>
>         We had about 2900 messages in mqueue.in/ , and reading through
> the list
>real quick, I noted someone had opted to delete their mqueue.in to fix the
>problem.  That would probably have not been an acceptable choice.
>         I modified logger.pl to print a line for every Sys::Syslog line, so I
>could se what it was trying to do on the console..  Here's what I ended up
>seeing:
>
>Printing Debug to Sys::Syslog, SpamAssassin returned 0
>Printing Debug to Sys::Syslog, Going to scan 100 messages
>Printing Debug to Sys::Syslog, Commencing scanning by mcafee...
>Printing Info to Sys::Syslog /g7N98C2j022911/%nTips.pif        Found the
>W32/Klez.h at MM virus !!!
>Printing Debug to Sys::Syslog, Completed scanning by mcafee
>Printing to Sys::Syslog Commercial virus checker failed with real error:
>Modification of a read-only value attempted at
>/usr/lib/perl5/5.8.0/i686-linux/Sys/Syslog.pm line 296, <KID> line 2.
>Closing Sys::Syslog (2)
>
>         It seems when sub InfoLog tries to print the "%n", that bombs it
> out.  I
>didn't want to go molesting your code any more than I needed to, so I just
>went
>into that message's file(dfg7N98C2j022911), and changed this block:
>
>--- begin
>Content-Type: application/octet-stream;
>         name=%nTips.pif
>Content-Transfer-Encoding: base64
>Content-ID: <L3kHd9QbKZ9H1vv62R>
>--- end
>
>To this:
>
>--- begin
>Content-Type: application/octet-stream;
>         name=Tips.pif
>Content-Transfer-Encoding: base64
>Content-ID: <L3kHd9QbKZ9H1vv62R>
>--- end
>
>
>         When I restarted mailscanner this time, it went through fine.
>Unfortunately, we were up to 3400 messages in the queue at that point.  Now
>we're down to 2900, so it's getting through, but my users are upset they
>didn't
>get their mail all day..  They'll live. :)
>
>         If you need, I can give you the message files to work with, but it's
>just something in how Sys::Syslog is handling the '%' character.
>
>
>         BTW, I'm running Perl 5.8.0 and MailScanner 3.22-12
-------------- next part --------------
A non-text attachment was scrubbed...
Name: separate_patches.tar.gz
Type: application/octet-stream
Size: 3486 bytes
Desc: not available
Url : http://lists.mailscanner.info/pipermail/mailscanner/attachments/20020823/c0cda52c/separate_patches.tar.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: all_bin.patch.gz
Type: application/octet-stream
Size: 3198 bytes
Desc: not available
Url : http://lists.mailscanner.info/pipermail/mailscanner/attachments/20020823/c0cda52c/all_bin.patch.obj
-------------- next part --------------
--
Julian Field                Teaching Systems Manager
jkf at ecs.soton.ac.uk         Dept. of Electronics & Computer Science
Tel. 023 8059 2817          University of Southampton
                             Southampton SO17 1BJ