Disinfection speed bogosity

[Jeff A. Earickson]

Julian,

I cranked in the change below.  Now I'm seeing a whole lot of:

Spam Checks completed at 1000000 bytes per second
MCP Checks completed at 1000000 bytes per second
Virus Processing completed at 1000000 bytes per second
Disinfection completed at 1000000 bytes per second

Not everything gives 1000000 for the "completed at" syslog statements, 
but most of the syslog output does.  My setup is Solaris 10 (Sparc, 64 bit), 
with sophos and clamavmodule.

I don't deliver cleaned messages, and I don't use MCP, so maybe I 
should not be seeing the "MCP check completed" and "Disinfection completed"
timing syslogs at all -- they don't happen for me, right?

When I was looking at the code, I wondered about the differences
in logic in MessageBatch.pm between EndBatch (lines 102-108) and
StopTiming (lines 136-166).  The minimum cutoff for

$totaltime = 1 unless $totaltime > ???

is different for the two sections.  Is this really what you want?

Jeff Earickson
Colby College

On Mon, 24 Jul 2006, Julian Field wrote:

> Date: Mon, 24 Jul 2006 22:11:06 +0100
> From: Julian Field <MailScanner at ecs.soton.ac.uk>
> Reply-To: MailScanner Beta-testers <mailscanner-beta at lists.mailscanner.info>
> To: MailScanner Beta-testers <mailscanner-beta at lists.mailscanner.info>
> Subject: Re: Disinfection speed bogosity
> 
>
> On Mon24 Jul 06, at 21:43, Jeff A. Earickson wrote:
>
>> Julian,
>> 
>> I just noticed totally bogus disinfection speeds in my syslog for
>> 4.55.8 (and 4.55.7), stuff like:
>> 
>> Disinfection completed at 1080796982 bytes per second
>> Disinfection completed at -1554448642 bytes per second
>> Disinfection completed at -1 bytes per second
>> 
>> Looking at around line 162 of MessageBatch.pm, I would guess that
>> this routine never got the Time::HiRes retrofit since the minimum
>> time there seems to be one second.  Is this a bug?
>
> Around like 158 make the code look like this: (note the 1 extra line in the 
> middle)
>
> $totaltime = 1 unless $totaltime > 0; # Minimum of 1 second
> # speed = bytes / totaltime
> $speed = ($this->{totalbytes}*1.0) / ($totaltime*1.0) if $totaltime > 0;
> $speed = 1_000_000 if $speed > 1_000_000 or $speed < 0; # THIS IS NEW
> # bytespersecond = speed
> $command = '$this->{' . $varprefix . '_bytespersecond} = $speed;';
> eval $command;
>
>
>> 
>> Jeff Earickson
>> Colby College
>> -- 
>> MailScanner-Beta mailing list
>> mailscanner-beta at lists.mailscanner.info
>> http://lists.mailscanner.info/mailman/listinfo/mailscanner-beta
>> 
>> Before posting, read http://wiki.mailscanner.info/posting
>> 
>> Support MailScanner development - buy the book off the website!
>
> --
> Julian Field
> www.MailScanner.info
> Buy the MailScanner book at www.MailScanner.info/store !
> PGP footprint: EE81 D763 3DB0 0BFD E1DC 7222 11F6 5947 1415 B654
>
>
>
> -- 
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
> MailScanner thanks transtec Computers for their support.
>
> -- 
> MailScanner-Beta mailing list
> mailscanner-beta at lists.mailscanner.info
> http://lists.mailscanner.info/mailman/listinfo/mailscanner-beta
>
> Before posting, read http://wiki.mailscanner.info/posting
>
> Support MailScanner development - buy the book off the website!